DescriptionRevert of Disable exceptions on Windows also in the shared_library build (https://codereview.chromium.org/404853002/)
Reason for revert:
Speculative revert to try to fix chrome_elf_unittests on Win7 x64.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%282%29/builds/18370
AddDllsFromRegistryToBlacklist
LoadBlacklistedLibrary
I'll reland if that's not it.
Original issue's description:
> Disable exceptions on Windows also in the shared_library build
>
> They were previously only disabled in static_library builds. This is believed
> to have been due to problems with old MSVC versions, but it should work now.
>
> This change is relevant for Clang, which currently doesn't support exceptions
> on Windows.
>
> Last time I attempted to do this, it broke some tests due to a debug assertion.
> Gtest had previously been catching the exception, but with exceptions disabled
> it crashed. Those tests were actually broken in static_library Debug builds
> too, but we don't seem to have bots for that. After Blink r176189, we no longer
> hit that debug assertion, so the tests now pass.
>
> BUG=82385
> TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
> content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
> webkit_unit_tests
>
> R=thakis@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284519
TBR=maruel@chromium.org,thakis@chromium.org,hans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284626
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|