Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/web_dev_style/regex_check.py

Issue 410603002: web_dev_style: add presubmit for superfluous </include> tags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_dev_style/js_checker.py ('k') | chrome/browser/web_dev_style/resource_checker.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/regex_check.py
diff --git a/chrome/browser/web_dev_style/regex_check.py b/chrome/browser/web_dev_style/regex_check.py
new file mode 100644
index 0000000000000000000000000000000000000000..d505e4223695745473409828e1b3291f5a006e11
--- /dev/null
+++ b/chrome/browser/web_dev_style/regex_check.py
@@ -0,0 +1,28 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+
+def RegexCheck(re, line_number, line, regex, msg):
+ """Searches for |regex| in |line| to check for a particular style
+ violation, returning a message like the one below if the regex matches.
+ The |regex| must have exactly one capturing group so that the relevant
+ part of |line| can be highlighted. If more groups are needed, use
+ "(?:...)" to make a non-capturing group. Sample message:
+
+ line 6: Use var instead of const.
+ const foo = bar();
+ ^^^^^
+ """
+
+ def _highlight(match):
+ """Takes a start position and a length, and produces a row of '^'s to
+ highlight the corresponding part of a string.
+ """
+ return match.start(1) * ' ' + (match.end(1) - match.start(1)) * '^'
+
+ match = re.search(regex, line)
+ if match:
+ assert len(match.groups()) == 1
+ return ' line %d: %s\n%s\n%s' % (line_number, msg, line, _highlight(match))
+ return ''
« no previous file with comments | « chrome/browser/web_dev_style/js_checker.py ('k') | chrome/browser/web_dev_style/resource_checker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698