Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 410553002: Cleanup: Remove redundant MockGetAuthTokenFunction, add missing cases (Closed)

Created:
6 years, 5 months ago by Michael Courage
Modified:
6 years, 5 months ago
Reviewers:
fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove redundant MockGetAuthTokenFunction, add missing cases In a previous change, an improved test subclass of GetAuthTokenFunction was created for multi-login tests. All chrome.identity.getAuthToken browser tests now use this class, and the original test class has been removed. The new class does not have any mock methods since the originals were not testing anything interesting anyway, and does not need to be a friend of its base class. This change also adds some coverage for error cases in getAuthToken, for requests specifying a non-primary account ID. BUG=364203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285020

Patch Set 1 #

Patch Set 2 : remove MockGetAuthTokenFunction references from GetAuthTokenFunction #

Patch Set 3 : add negative cases for secondary accounts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -303 lines) Patch
M chrome/browser/extensions/api/identity/identity_api.h View 1 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 2 55 chunks +229 lines, -298 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Michael Courage
6 years, 5 months ago (2014-07-22 18:21:20 UTC) #1
fgorski
On 2014/07/22 18:21:20, Michael Courage wrote: lgtm
6 years, 5 months ago (2014-07-22 20:09:25 UTC) #2
Michael Courage
The CQ bit was checked by courage@chromium.org
6 years, 5 months ago (2014-07-22 20:16:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/410553002/40001
6 years, 5 months ago (2014-07-22 20:18:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 23:25:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 01:20:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31132)
6 years, 5 months ago (2014-07-23 01:20:39 UTC) #7
Michael Courage
The CQ bit was checked by courage@chromium.org
6 years, 5 months ago (2014-07-23 19:48:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/410553002/40001
6 years, 5 months ago (2014-07-23 19:50:22 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 19:52:56 UTC) #10
Message was sent while issue was closed.
Change committed as 285020

Powered by Google App Engine
This is Rietveld 408576698