Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 410523002: cc: Add eviction tile queue construct (and iterate) perftests. (Closed)

Created:
6 years, 5 months ago by vmpstr
Modified:
6 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add eviction tile queue construct (and iterate) perftests. This patch adds construct as well as construct and iterate perftests for the eviction tile priority queue. Initial runs (from my macbook): [ RUN ] TileManagerPerfTest.EvictionTileQueueConstruct *RESULT tile_manager_eviction_tile_queue_construct: 2= 412610.25 runs/s *RESULT tile_manager_eviction_tile_queue_construct: 10= 48552.328125 runs/s *RESULT tile_manager_eviction_tile_queue_construct: 100= 1245.8426513671875 runs/s [ OK ] TileManagerPerfTest.EvictionTileQueueConstruct (6185 ms) [ RUN ] TileManagerPerfTest.EvictionTileQueueConstructAndIterate *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_16= 3109.413818359375 runs/s *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_32= 2810.639404296875 runs/s *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_64= 2365.239990234375 runs/s *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_128= 1793.8878173828125 runs/s [ OK ] TileManagerPerfTest.EvictionTileQueueConstructAndIterate (8358 ms) R=reveman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285645

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
M cc/resources/tile_manager_perftest.cc View 1 2 chunks +108 lines, -0 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
vmpstr
PTAL
6 years, 5 months ago (2014-07-22 00:13:06 UTC) #1
reveman
lgtm
6 years, 5 months ago (2014-07-22 00:14:27 UTC) #2
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-24 16:46:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/410523002/1
6 years, 5 months ago (2014-07-24 16:47:24 UTC) #4
vmpstr
The CQ bit was unchecked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-24 18:25:35 UTC) #5
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-25 16:40:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/410523002/20001
6 years, 5 months ago (2014-07-25 16:41:40 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 18:42:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 18:51:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/46797)
6 years, 5 months ago (2014-07-25 18:51:03 UTC) #10
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-25 19:13:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/410523002/20001
6 years, 5 months ago (2014-07-25 19:14:43 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 19:54:58 UTC) #13
Message was sent while issue was closed.
Change committed as 285645

Powered by Google App Engine
This is Rietveld 408576698