Assertion removed in print_preview_pdf_generated.cc.

chrome/browser/ui/webui/print_preview/print_preview_ui.h

Index: chrome/browser/ui/webui/print_preview/print_preview_ui.h
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.h b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
index be4f82b75d50accba488ae80ea4e4fd65cf5d240..637d5797a9887c5b0c300349ef5672da073ae7cf 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.h
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
@@ -7,6 +7,7 @@
 
 #include <string>
 
+#include "base/callback.h"

[ivandavid, 2014/07/21 23:58:28]

This needed to be included. I attempted to do the same thing as base::FilePath,
however the compiler said I was redefining the class.

[Lei Zhang, 2014/07/22 00:11:30]

You need to #include "base/callback_forward.h" instead.

[ivandavid, 2014/07/22 02:40:26]

Done.

 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/time/time.h"
@@ -159,6 +160,8 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {
   // the printing without having to click a button on the print preview dialog.
   void SetSelectedFileForTesting(const base::FilePath& path);
 
+  void SetCallbackForTesting(const base::Closure* callback);

[Lei Zhang, 2014/07/22 00:11:30]

This name is really vague. There's thousands of callbacks in Chrome for all
kinds of things. What does this callback do exactly?

[Lei Zhang, 2014/07/22 00:11:30]

Callbacks are passed by const reference, not via pointer.

[ivandavid, 2014/07/22 02:40:26]

Done.

[ivandavid, 2014/07/22 02:40:26]

Done.

+
  private:
   friend class PrintPreviewHandlerTest;
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsCustom);