chrome/browser/ui/webui/print_preview/print_preview_handler.h - Issue 410473002: Assertion removed in print_preview_pdf_generated.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.h

Issue 410473002: Assertion removed in print_preview_pdf_generated.cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Assert to check validity of |PrintPreviewObserver::pdf_file_save_path_| moved. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_pdf_generated_browsertest.cc ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_handler.h

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.h b/chrome/browser/ui/webui/print_preview/print_preview_handler.h

index 4f024968009ce7b116fb59532f41539a15c1892a..88b5f5c8bc4ac23e634a3dc570e162959763a6bc 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.h

+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.h

@@ -105,6 +105,9 @@ class PrintPreviewHandler

return regenerate_preview_request_count_;

}

+ // Sets |pdf_file_saved_closure_| to |closure|.

+ void SetPdfSavedClosureForTesting(const base::Closure& closure);

private:

friend class PrintPreviewPdfGeneratedBrowserTest;

FRIEND_TEST_ALL_PREFIXES(PrintPreviewPdfGeneratedBrowserTest,

@@ -332,6 +335,10 @@ class PrintPreviewHandler

base::WeakPtrFactory<PrintPreviewHandler> weak_factory_;

+ // Notifies tests that want to know if the PDF has been saved. This doesn't

+ // notify the test if it was a successful save, only that it was attempted.

+ base::Closure pdf_file_saved_closure_;

DISALLOW_COPY_AND_ASSIGN(PrintPreviewHandler);

};