chrome/browser/ui/webui/print_preview/print_preview_ui.h - Issue 410473002: Assertion removed in print_preview_pdf_generated.cc.

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.h

Issue 410473002: Assertion removed in print_preview_pdf_generated.cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed |end_loop_callback_|. Observer didn't need it as a member variable. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('K') | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | chrome/browser/ui/webui/print_preview/print_preview_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui.h

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.h b/chrome/browser/ui/webui/print_preview/print_preview_ui.h

index be4f82b75d50accba488ae80ea4e4fd65cf5d240..924b6cec0580ada2c66ed066dbcc66e6729ab992 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.h

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.h

@@ -7,6 +7,7 @@

#include <string>

+#include "base/callback_forward.h"

#include "base/gtest_prod_util.h"

#include "base/memory/ref_counted.h"

#include "base/time/time.h"

@@ -159,6 +160,10 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {

// the printing without having to click a button on the print preview dialog.

void SetSelectedFileForTesting(const base::FilePath& path);

+ // Sets |pdf_file_saved_callback_| to |callback|. The callback is used to end

Lei Zhang 2014/07/22 03:04:39 This doesn't make sense in this context. PrintPrev

ivandavid 2014/07/22 19:02:01 Done.

ivandavid 2014/07/22 19:02:01 Guess that's why I shouldn't copy paste comments :

+ // the message loop in PrintPreviewObserver in print_preview_pdf_generated.cc.

Lei Zhang 2014/07/22 03:04:39 print_preview_pdf_generated.cc also doesn't exist,

ivandavid 2014/07/22 19:02:01 Done.

+ void SetPdfSavedCallbackForTesting(const base::Closure& callback);

private:

friend class PrintPreviewHandlerTest;

FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsCustom);