Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2849)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.h

Issue 410473002: Assertion removed in print_preview_pdf_generated.cc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed |end_loop_callback_|. Observer didn't need it as a member variable. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.h
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.h b/chrome/browser/ui/webui/print_preview/print_preview_handler.h
index 4f024968009ce7b116fb59532f41539a15c1892a..6669726b6cf4dc3149503222ac3ef9720a23dc47 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.h
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.h
@@ -104,6 +104,9 @@ class PrintPreviewHandler
int regenerate_preview_request_count() const {
return regenerate_preview_request_count_;
}
+ // Sets |pdf_file_saved_callback_| to |callback|. The callback is used to end
+ // the message loop in PrintPreviewObserver in print_preview_pdf_generated.cc.
+ void SetPdfSavedCallbackForTesting(const base::Closure& callback);
private:
friend class PrintPreviewPdfGeneratedBrowserTest;
@@ -332,6 +335,10 @@ class PrintPreviewHandler
base::WeakPtrFactory<PrintPreviewHandler> weak_factory_;
+ // Ends message loop for PrintPreviewObserver in
+ // print_preview_pdf_generated.cc.
+ base::Closure pdf_file_saved_callback_;
+
DISALLOW_COPY_AND_ASSIGN(PrintPreviewHandler);
};

Powered by Google App Engine
This is Rietveld 408576698