Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 410443002: Revert of Revert of Cast: Log playout delay from receiver (Closed)

Created:
6 years, 5 months ago by Alpha Left Google
Modified:
6 years, 5 months ago
Reviewers:
dgozman, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Cast: Log playout delay from receiver (https://codereview.chromium.org/401273002/) Reason for revert: This revert wouldn't solve the flakiness. The fix for flakiness is in CQ now. Reverting this. Original issue's description: > Revert of Cast: Log playout delay from receiver (https://codereview.chromium.org/401213002/) > > Reason for revert: > This patch seems to break CastStreamingApiTestWithPixelOutput.EndToEnd. > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32598/steps/browser_tests/logs/EndToEnd > > Original issue's description: > > Cast: Log playout delay from receiver > > > > The last refactoring in RTCP handling dropped the playout delay from > > receiver. This change adds it back. > > > > TBR=miu > > BUG=393042 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284395 > > TBR=miu@chromium.org,hclam@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=393042 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284411 TBR=miu@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=393042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M chrome/renderer/media/cast_session_delegate.cc View 1 chunk +18 lines, -7 lines 0 comments Download
M media/cast/test/simulator.cc View 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
Created Revert of Revert of Cast: Log playout delay from receiver
6 years, 5 months ago (2014-07-21 18:10:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/410443002/1
6 years, 5 months ago (2014-07-21 18:12:27 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 18:14:28 UTC) #3
Message was sent while issue was closed.
Change committed as 284462

Powered by Google App Engine
This is Rietveld 408576698