Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 410433002: Cast: Avoid hitting a DCHECK caused by race condition (Closed)

Created:
6 years, 5 months ago by Alpha Left Google
Modified:
6 years, 5 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cast: Avoid hitting a DCHECK caused by race condition RTCP sender report has a race condition when then current time is submitted asynchronously (from another process). This caused the value for DLRR to be negative. This code is going to be removed it is fine to just suppress this condition. BUG=393042 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284521

Patch Set 1 #

Patch Set 2 : flakr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M media/cast/net/rtcp/rtcp.cc View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 5 months ago (2014-07-21 18:07:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/410433002/20001
6 years, 5 months ago (2014-07-21 18:09:06 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 20:04:10 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 20:06:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/172213)
6 years, 5 months ago (2014-07-21 20:06:59 UTC) #5
miu
lgtm
6 years, 5 months ago (2014-07-21 21:21:19 UTC) #6
miu
The CQ bit was unchecked by miu@chromium.org
6 years, 5 months ago (2014-07-21 21:21:29 UTC) #7
miu
The CQ bit was checked by miu@chromium.org
6 years, 5 months ago (2014-07-21 21:22:03 UTC) #8
miu
On 2014/07/21 21:22:03, miu wrote: > The CQ bit was checked by mailto:miu@chromium.org Submitting w/ ...
6 years, 5 months ago (2014-07-21 21:22:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/410433002/20001
6 years, 5 months ago (2014-07-21 21:23:11 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 22:38:05 UTC) #11
Message was sent while issue was closed.
Change committed as 284521

Powered by Google App Engine
This is Rietveld 408576698