Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 410423005: Disable flaky RenderFrameHostManagerTest.DisownOpener on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <set> 5 #include <set>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/json/json_reader.h" 8 #include "base/json/json_reader.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 EXPECT_TRUE(ExecuteScriptAndExtractBool( 404 EXPECT_TRUE(ExecuteScriptAndExtractBool(
405 shell()->web_contents(), 405 shell()->web_contents(),
406 "window.domAutomationController.send(testCloseWindow());", 406 "window.domAutomationController.send(testCloseWindow());",
407 &success)); 407 &success));
408 EXPECT_TRUE(success); 408 EXPECT_TRUE(success);
409 close_watcher.Wait(); 409 close_watcher.Wait();
410 } 410 }
411 411
412 // Test that setting the opener to null in a window affects cross-process 412 // Test that setting the opener to null in a window affects cross-process
413 // navigations, including those to existing entries. http://crbug.com/156669. 413 // navigations, including those to existing entries. http://crbug.com/156669.
414 // Flaky on android: http://crbug.com/397185
414 // Flaky on windows: http://crbug.com/291249 415 // Flaky on windows: http://crbug.com/291249
415 // This test also crashes under ThreadSanitizer, http://crbug.com/356758. 416 // This test also crashes under ThreadSanitizer, http://crbug.com/356758.
416 #if defined(OS_WIN) || defined(THREAD_SANITIZER) 417 #if defined(OS_ANDROID) || defined(OS_WIN) || defined(THREAD_SANITIZER)
417 #define MAYBE_DisownOpener DISABLED_DisownOpener 418 #define MAYBE_DisownOpener DISABLED_DisownOpener
418 #else 419 #else
419 #define MAYBE_DisownOpener DisownOpener 420 #define MAYBE_DisownOpener DisownOpener
420 #endif 421 #endif
421 IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest, MAYBE_DisownOpener) { 422 IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest, MAYBE_DisownOpener) {
422 StartServer(); 423 StartServer();
423 424
424 // Load a page with links that open in a new window. 425 // Load a page with links that open in a new window.
425 std::string replacement_path; 426 std::string replacement_path;
426 ASSERT_TRUE(GetFilePathWithHostAndPortReplacement( 427 ASSERT_TRUE(GetFilePathWithHostAndPortReplacement(
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
1456 // Navigate to url1 and check bindings. 1457 // Navigate to url1 and check bindings.
1457 NavigateToURL(new_shell, url1); 1458 NavigateToURL(new_shell, url1);
1458 // The navigation should have used the first SiteInstance, otherwise 1459 // The navigation should have used the first SiteInstance, otherwise
1459 // |initial_rvh| did not have a chance to be used. 1460 // |initial_rvh| did not have a chance to be used.
1460 EXPECT_EQ(new_web_contents->GetSiteInstance(), site_instance1); 1461 EXPECT_EQ(new_web_contents->GetSiteInstance(), site_instance1);
1461 EXPECT_EQ(BINDINGS_POLICY_WEB_UI, 1462 EXPECT_EQ(BINDINGS_POLICY_WEB_UI,
1462 new_web_contents->GetRenderViewHost()->GetEnabledBindings()); 1463 new_web_contents->GetRenderViewHost()->GetEnabledBindings());
1463 } 1464 }
1464 1465
1465 } // namespace content 1466 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698