Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 410413008: Revert of content: Remove RendererPreferences font-rendering enums. (Closed)

Created:
6 years, 5 months ago by johnme
Modified:
6 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of content: Remove RendererPreferences font-rendering enums. (https://codereview.chromium.org/413523004/) Reason for revert: This caused* the following 3 layout tests to regress[1] on WebKit Android (Nexus4). - css1/font_properties/font_variant.html - fast/text/chromium-linux-fontconfig-renderstyle.html - svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg Specifically the results[2] show that the text rendering has changed slightly, and from manual inspection the hinting seems worse (e.g. some 1 pixel wide black lines have become spread into 2-pixel wide gray lines). *: (it's the only font-related patch on the blamelist[3]) [1]: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20(Nexus4)/builds/16906 [2]: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Android__Nexus4_/16906/layout-test-results/results.html [3]: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=%2Ftrunk%2Fsrc&range=285141%3A285145&mode=html Original issue's description: > content: Remove RendererPreferences font-rendering enums. > > Make the RendererPreferences message struct use enums from > gfx::FontRenderParams instead of defining its own. > > This also drops the SYSTEM_DEFAULT values for hinting and > subpixel rendering. They weren't getting used anywhere. > > BUG=393243 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285145 TBR=jochen@chromium.org,boliu@chromium.org,jln@chromium.org,msw@chromium.org,derat@chromium.org NOTREECHECKS=true NOTRY=true BUG=393243 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -66 lines) Patch
M android_webview/native/aw_settings.cc View 2 chunks +43 lines, -2 lines 0 comments Download
M chrome/browser/renderer_preferences_util.cc View 2 chunks +47 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/renderer_preferences.h View 3 chunks +19 lines, -3 lines 0 comments Download
M content/public/common/renderer_preferences.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_view_linux.cc View 2 chunks +71 lines, -49 lines 0 comments Download
M ui/gfx/font_render_params.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
johnme
Created Revert of content: Remove RendererPreferences font-rendering enums.
6 years, 5 months ago (2014-07-24 15:54:24 UTC) #1
Daniel Erat
lgtm
6 years, 5 months ago (2014-07-24 15:55:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/410413008/1
6 years, 5 months ago (2014-07-24 15:55:10 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 16:03:56 UTC) #4
Message was sent while issue was closed.
Change committed as 285292

Powered by Google App Engine
This is Rietveld 408576698