Issue 410413007: Always trace garbage collection events in GCTracer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 410413007: Always trace garbage collection events in GCTracer. (Closed)

Created:
6 years, 5 months ago by ernstm

Modified:
6 years, 5 months ago

Reviewers:
Hannes Payer (out of office), jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Always trace garbage collection events in GCTracer. - always trace events in GCTracer, but only print stats when the command line flag is set. - required to collect statistis that will be used to schedue garbage collection. - we need to watch the perf bots after this lands, as it could regress performance. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22613

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -17 lines)			Patch
	M	src/gc-tracer.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
	M	src/incremental-marking.cc	View		2 chunks	+5 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, but lets make sure that we do not tank performance.

6 years, 5 months ago (2014-07-24 16:32:09 UTC) #2

ernstm

6 years, 5 months ago (2014-07-25 07:32:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22613 (presubmit successful).

Expand Messages | Collapse Messages