Issue 410413005: Add event statistics to GCTracer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 410413005: Add event statistics to GCTracer. (Closed)

Created:
6 years, 5 months ago by ernstm

Modified:
6 years, 5 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add event statistics to GCTracer. - Add method to GCTracer to compute mean and max of the last few Scavenger, Mark Compactor and Incremental Marking events. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22605

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comments. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -0 lines)			Patch
	M	src/gc-tracer.h	View	1	2 chunks	+36 lines, -0 lines	0 comments	Download
	M	src/gc-tracer.cc	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, just nits. https://codereview.chromium.org/410413005/diff/1/src/gc-tracer.h File src/gc-tracer.h (right): https://codereview.chromium.org/410413005/diff/1/src/gc-tracer.h#newcode205 src/gc-tracer.h:205: // Compute the mean duration of ...

6 years, 5 months ago (2014-07-24 15:16:40 UTC) #2

ernstm

https://codereview.chromium.org/410413005/diff/1/src/gc-tracer.h File src/gc-tracer.h (right): https://codereview.chromium.org/410413005/diff/1/src/gc-tracer.h#newcode205 src/gc-tracer.h:205: // Compute the mean duration of the last scavenger ...

6 years, 5 months ago (2014-07-24 15:22:39 UTC) #3

ernstm

6 years, 5 months ago (2014-07-24 15:23:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22605 (presubmit successful).

Expand Messages | Collapse Messages