Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 410413002: Range.comparePoint should throw TypeError when refNode is not an object (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
haraken, sof, Yuta Kitamura
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Range.comparePoint should throw TypeError when refNode is not an object SPEC: http://www.w3.org/TR/WebIDL/#es-interface A failed test case will be passed with this CL in http://w3c-test.org/dom/ranges/Range-comparePoint-2.html TEST=LayoutTests/fast/dom/Range/range-comparePoint.html Behavior in other browsers. *)FF: PASS *)IE: PASS Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M LayoutTests/fast/dom/Range/range-comparePoint.html View 2 chunks +10 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-comparePoint-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Range.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kangil_
PTAL
6 years, 5 months ago (2014-07-24 07:21:08 UTC) #1
haraken
LGTM, given the spec and the behavior of Firefox and IE.
6 years, 5 months ago (2014-07-24 07:39:58 UTC) #2
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-24 07:52:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/410413002/1
6 years, 5 months ago (2014-07-24 07:52:52 UTC) #4
commit-bot: I haz the power
Change committed as 178828
6 years, 5 months ago (2014-07-24 09:00:06 UTC) #5
sof
It throws already, albeit not TypeError. Do we need both checks?
6 years, 5 months ago (2014-07-24 10:52:21 UTC) #6
kangil_
On 2014/07/24 10:52:21, sof wrote: > It throws already, albeit not TypeError. Do we need ...
6 years, 5 months ago (2014-07-24 11:27:37 UTC) #7
kangil_
6 years, 5 months ago (2014-07-24 11:53:58 UTC) #8
Message was sent while issue was closed.
On 2014/07/24 11:27:37, kangil_ wrote:
> On 2014/07/24 10:52:21, sof wrote:
> > It throws already, albeit not TypeError. Do we need both checks?
> 
> Ah, my bad.
> Null check should be deleted in Range::comparePoint since it is not necessary
> anymore.
> I will make a follow-up CL for that.
> Thanks for information. :)

Uploaded at https://codereview.chromium.org/412143007/

Powered by Google App Engine
This is Rietveld 408576698