Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 410383003: Make Pepper WebSocket UtilityGetProtocol test less flaky by making the wsh wait for close (Closed)

Created:
6 years, 5 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 5 months ago
Reviewers:
Johnny, yhirano
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make Pepper WebSocket UtilityGetProtocol test less flaky by making the wsh wait for close Attempt to fix the flakiness by making sure the server handler doesn't exit before the client closes. BUG=389084 R=jgraettinger,yhirano Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/data/websocket/protocol-test_wsh.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 5 months ago (2014-07-24 05:22:40 UTC) #1
yhirano
lgtm
6 years, 5 months ago (2014-07-24 05:40:17 UTC) #2
tyoshino (SeeGerritForStatus)
+jgraettinger
6 years, 5 months ago (2014-07-24 05:42:49 UTC) #3
Johnny
lgtm
6 years, 5 months ago (2014-07-24 14:34:56 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 5 months ago (2014-07-25 03:28:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/410383003/1
6 years, 5 months ago (2014-07-25 03:30:47 UTC) #6
tyoshino (SeeGerritForStatus)
The CQ bit was unchecked by tyoshino@chromium.org
6 years, 5 months ago (2014-07-25 03:31:53 UTC) #7
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 5 months ago (2014-07-25 03:32:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/410383003/1
6 years, 5 months ago (2014-07-25 03:33:12 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 06:05:33 UTC) #10
Message was sent while issue was closed.
Change committed as 285500

Powered by Google App Engine
This is Rietveld 408576698