Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 410333005: Remove the drive status from the ash try. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
stevenjb, Daniel Erat
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove the drive status from the ash try. The drive status is shown in Files.app now. We can remove the status from the ash try. BUG=379979 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285493

Patch Set 1 #

Patch Set 2 : Fix windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -864 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/chromeos/enterprise/tray_enterprise.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 1 chunk +1 line, -0 lines 0 comments Download
D ash/system/drive/drive_observer.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ash/system/drive/tray_drive.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ash/system/drive/tray_drive.cc View 1 chunk +0 lines, -517 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 3 chunks +0 lines, -41 lines 0 comments Download
M ash/system/tray/system_tray_delegate.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 4 chunks +0 lines, -6 lines 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 6 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 12 chunks +2 lines, -137 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_linux.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_win.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hirono
PTAL the CL? @stevenjb - ash/system* @derat - chrome/browser/ui/ash/* Thank you!
6 years, 5 months ago (2014-07-24 04:47:23 UTC) #1
Daniel Erat
rubberstamp lgtm for c/b/ui/ash
6 years, 5 months ago (2014-07-24 13:24:58 UTC) #2
stevenjb
lgtm
6 years, 5 months ago (2014-07-24 17:14:54 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-25 00:59:12 UTC) #4
hirono
The CQ bit was unchecked by hirono@chromium.org
6 years, 5 months ago (2014-07-25 01:00:09 UTC) #5
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-25 01:07:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/410333005/20001
6 years, 5 months ago (2014-07-25 01:09:31 UTC) #7
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-25 02:08:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/410333005/20001
6 years, 5 months ago (2014-07-25 02:25:57 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 05:46:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 285493

Powered by Google App Engine
This is Rietveld 408576698