chrome/browser/resources/options/hotword_confirm_dialog.js - Issue 410293004: Split OptionsPage into Page and PageManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/hotword_confirm_dialog.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: s/PageTree/PageManager/, s/pageHelper/pageManager/ Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/hotword_confirm_dialog.js

diff --git a/chrome/browser/resources/options/hotword_confirm_dialog.js b/chrome/browser/resources/options/hotword_confirm_dialog.js

index c32b77287edd8947815fa48a424c669b1e82e815..c759540ecafdae8750cf53065808e1842fe1bd9c 100644

--- a/chrome/browser/resources/options/hotword_confirm_dialog.js

+++ b/chrome/browser/resources/options/hotword_confirm_dialog.js

@@ -5,7 +5,7 @@

cr.define('options', function() {

/** @const */ var ConfirmDialog = options.ConfirmDialog;

/** @const */ var SettingsDialog = options.SettingsDialog;

- /** @const */ var OptionsPage = options.OptionsPage;

+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;

/**

* A dialog that will pop up when the user attempts to set the value of the

@@ -48,7 +48,7 @@ cr.define('options', function() {

if (event.value.value && !this.confirmed_) {

if (!this.indicator.errorText) {

- OptionsPage.showPageByName(this.name, false);

+ PageManager.showPageByName(this.name, false);

} else {

this.indicator.updateBasedOnError();

this.handleCancel();