Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/resources/options/alert_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/PageTree/PageManager/, s/pageHelper/pageManager/ Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/alert_overlay.js
diff --git a/chrome/browser/resources/options/alert_overlay.js b/chrome/browser/resources/options/alert_overlay.js
index aab11765e671258cfa6e6977e7087ed7ab76f7e4..757ebca2fbd0f3372eec527e804d98ad871ad347 100644
--- a/chrome/browser/resources/options/alert_overlay.js
+++ b/chrome/browser/resources/options/alert_overlay.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* AlertOverlay class
@@ -11,14 +12,14 @@ cr.define('options', function() {
* @class
*/
function AlertOverlay() {
- OptionsPage.call(this, 'alertOverlay', '', 'alertOverlay');
+ Page.call(this, 'alertOverlay', '', 'alertOverlay');
}
cr.addSingletonGetter(AlertOverlay);
AlertOverlay.prototype = {
- // Inherit AlertOverlay from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit AlertOverlay from Page.
+ __proto__: Page.prototype,
/**
* Whether the page can be shown. Used to make sure the page is only
@@ -31,8 +32,7 @@ cr.define('options', function() {
* Initialize the page.
*/
initializePage: function() {
- // Call base class implementation to start preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var self = this;
$('alertOverlayOk').onclick = function(event) {
@@ -58,7 +58,7 @@ cr.define('options', function() {
* @private
*/
handleOK_: function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
if (this.okCallback != undefined) {
this.okCallback.call();
}
@@ -70,7 +70,7 @@ cr.define('options', function() {
* @private
*/
handleCancel_: function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
if (this.cancelCallback != undefined) {
this.cancelCallback.call();
}
@@ -142,7 +142,7 @@ cr.define('options', function() {
// Intentionally don't show the URL in the location bar as we don't want
// people trying to navigate here by hand.
- OptionsPage.showPageByName('alertOverlay', false);
+ PageManager.showPageByName('alertOverlay', false);
};
// Export

Powered by Google App Engine
This is Rietveld 408576698