chrome/browser/resources/options/hotword_search_setting_indicator.js - Issue 410293004: Split OptionsPage into Page and PageManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/hotword_search_setting_indicator.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ugh just no Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/hotword_confirm_dialog.js ('k') | chrome/browser/resources/options/import_data_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/hotword_search_setting_indicator.js

diff --git a/chrome/browser/resources/options/hotword_search_setting_indicator.js b/chrome/browser/resources/options/hotword_search_setting_indicator.js

index 2089e8a3ee987f978c218b243b7201fdbc604a78..a920e6c10f2d059cd6b022a76471cf3df2a0e59b 100644

--- a/chrome/browser/resources/options/hotword_search_setting_indicator.js

+++ b/chrome/browser/resources/options/hotword_search_setting_indicator.js

@@ -33,7 +33,7 @@ cr.define('options', function() {

* @override

handlePrefChange: function(event) {

- OptionsPage.hideBubble();

+ PageManager.hideBubble();

/**

@@ -82,7 +82,7 @@ cr.define('options', function() {

toggleBubble_: function() {

if (this.showingBubble) {

- OptionsPage.hideBubble();

+ PageManager.hideBubble();

return;

}

@@ -107,7 +107,7 @@ cr.define('options', function() {

var content = document.createElement('div');

content.appendChild(container);

- OptionsPage.showBubble(content, this.image, this, this.location);

+ PageManager.showBubble(content, this.image, this, this.location);

};