Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: chrome/browser/resources/options/chromeos/accounts_options.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/accounts_options.js
diff --git a/chrome/browser/resources/options/chromeos/accounts_options.js b/chrome/browser/resources/options/chromeos/accounts_options.js
index e438a2875bca55f33abe95fb3b079ca0c1286d11..4b80afc540895e41d6a08cdd0773dd8a0406a517 100644
--- a/chrome/browser/resources/options/chromeos/accounts_options.js
+++ b/chrome/browser/resources/options/chromeos/accounts_options.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/////////////////////////////////////////////////////////////////////////////
// AccountsOptions class:
@@ -13,9 +14,8 @@ cr.define('options', function() {
* @constructor
*/
function AccountsOptions(model) {
- OptionsPage.call(this, 'accounts',
- loadTimeData.getString('accountsPageTabTitle'),
- 'accountsPage');
+ Page.call(this, 'accounts', loadTimeData.getString('accountsPageTabTitle'),
+ 'accountsPage');
// Whether to show the whitelist.
this.showWhitelist_ = false;
}
@@ -23,13 +23,12 @@ cr.define('options', function() {
cr.addSingletonGetter(AccountsOptions);
AccountsOptions.prototype = {
- // Inherit AccountsOptions from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit AccountsOptions from Page.
+ __proto__: Page.prototype,
/** @override */
initializePage: function() {
- // Call base class implementation to starts preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
// Set up accounts page.
var userList = $('userList');
@@ -60,7 +59,7 @@ cr.define('options', function() {
this.handleUseWhitelistPrefChange_.bind(this));
$('accounts-options-overlay-confirm').onclick =
- OptionsPage.closeOverlay.bind(OptionsPage);
+ PageManager.closeOverlay.bind(PageManager);
},
/**
@@ -75,7 +74,7 @@ cr.define('options', function() {
},
/**
- * Handler for OptionsPage's visible property change event.
+ * Handler for Page's visible property change event.
* @private
* @param {Event} e Property change event.
*/

Powered by Google App Engine
This is Rietveld 408576698