chrome/browser/resources/options/chromeos/keyboard_overlay.js - Issue 410293004: Split OptionsPage into Page and PageManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/keyboard_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/chromeos/keyboard_overlay.js

diff --git a/chrome/browser/resources/options/chromeos/keyboard_overlay.js b/chrome/browser/resources/options/chromeos/keyboard_overlay.js

index 02f821a5db270a53462fb123c39f350e4c20c97d..a2d851897ab9421d33ccf09356f14c3672fa2f1c 100644

--- a/chrome/browser/resources/options/chromeos/keyboard_overlay.js

+++ b/chrome/browser/resources/options/chromeos/keyboard_overlay.js

@@ -62,7 +62,7 @@ cr.define('options', function() {

this.handleAutoRepeatIntervalPrefChange_.bind(this);

$('languages-and-input-settings').onclick = function(e) {

- OptionsPage.navigateToPage('languages');

+ PageManager.showPageByName('languages');

chrome.send('coreOptionsUserMetricsAction',

['Options_KeyboardShowLanguageSettings']);

};