chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js - Issue 410293004: Split OptionsPage into Page and PageManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/fake_bluetooth_overlay_parent.js ('K') | « chrome/browser/resources/chromeos/fake_bluetooth_overlay_parent.js ('k') | chrome/browser/resources/chromeos/proxy_settings.html » ('j') | chrome/browser/resources/options/alert_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js

diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js b/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js

index 78c2564542a7a179ede8e0971cfbdae7b23eaddc..9cd55003befd7682156aaa788c515eb9afc675fd 100644

--- a/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js

+++ b/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js

@@ -166,7 +166,7 @@ login.createScreen('HIDDetectionScreen', 'hid-detection', function() {

showPairingLayout: function(device) {

BluetoothPairing.getInstance().update(device);

- OptionsPage.showPageByName('bluetoothPairing', false);

+ PageManager.showPageByName('bluetoothPairing', false);

Dan Beam 2014/07/30 01:00:01 how is this finding the unprefixed name (e.g. no o

michaelpg 2014/07/30 21:42:19 good question. apparently this is unused code and

};

});