Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/resources/chromeos/fake_bluetooth_overlay_parent.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 var OptionsPage = options.OptionsPage; 6 var Page = cr.ui.pageManager.Page;
7 var PageManager = cr.ui.pageManager.PageManager;
7 8
8 /** 9 /**
9 * Encapsulated a fake parent page for bluetooth overlay page used by Web UI. 10 * Encapsulated a fake parent page for bluetooth overlay page used by Web UI.
10 * @constructor 11 * @constructor
11 */ 12 */
12 function FakeBluetoothOverlayParent(model) { 13 function FakeBluetoothOverlayParent(model) {
13 OptionsPage.call(this, 'bluetooth', 14 Page.call(this, 'bluetooth', '', 'bluetooth-container');
14 '',
15 'bluetooth-container');
16 } 15 }
17 16
18 cr.addSingletonGetter(FakeBluetoothOverlayParent); 17 cr.addSingletonGetter(FakeBluetoothOverlayParent);
19 18
20 FakeBluetoothOverlayParent.prototype = { 19 FakeBluetoothOverlayParent.prototype = {
21 // Inherit FakeBluetoothOverlayParent from OptionsPage. 20 // Inherit FakeBluetoothOverlayParent from Page.
22 __proto__: OptionsPage.prototype, 21 __proto__: Page.prototype,
23 22
24 /** 23 /**
25 * Initializes FakeBluetoothOverlayParent page. 24 * Initializes FakeBluetoothOverlayParent page.
26 */ 25 */
27 initializePage: function() { 26 initializePage: function() {
28 // Call base class implementation to starts preference initialization. 27 // Call base class implementation to starts preference initialization.
29 OptionsPage.prototype.initializePage.call(this); 28 Page.prototype.initializePage.call(this);
30 }, 29 },
Dan Beam 2014/07/30 01:00:01 in practice L22-29 is totally useless. redefining
michaelpg 2014/07/30 21:42:19 Thanks.
31 }; 30 };
32 31
33 // Export 32 // Export
34 return { 33 return {
35 FakeBluetoothOverlayParent: FakeBluetoothOverlayParent 34 FakeBluetoothOverlayParent: FakeBluetoothOverlayParent
36 }; 35 };
37 }); 36 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698