Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 410283003: test_runner: Migrate MockSpellCheck to Chromium C++ style. (Closed)

Created:
6 years, 5 months ago by Abhishek
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

test_runner: Migrate MockSpellCheck to Chromium C++ style. Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to mock_spell_check. BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285566

Patch Set 1 #

Total comments: 4

Patch Set 2 : variable names corrected #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Updated Build.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -267 lines) Patch
M content/content_shell.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/MockSpellCheck.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/shell/renderer/test_runner/MockSpellCheck.cpp View 1 chunk +0 lines, -184 lines 0 comments Download
M content/shell/renderer/test_runner/SpellCheckClient.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/SpellCheckClient.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A content/shell/renderer/test_runner/mock_spell_check.h View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/mock_spell_check.cc View 1 2 1 chunk +174 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jochen (gone - plz use gerrit)
https://codereview.chromium.org/410283003/diff/1/content/shell/renderer/test_runner/mock_spell_check.cc File content/shell/renderer/test_runner/mock_spell_check.cc (right): https://codereview.chromium.org/410283003/diff/1/content/shell/renderer/test_runner/mock_spell_check.cc#newcode33 content/shell/renderer/test_runner/mock_spell_check.cc:33: int* misspelledOffset, misspelled_offset https://codereview.chromium.org/410283003/diff/1/content/shell/renderer/test_runner/mock_spell_check.cc#newcode47 content/shell/renderer/test_runner/mock_spell_check.cc:47: base::string16 stringText = text; ...
6 years, 5 months ago (2014-07-24 08:47:05 UTC) #1
Abhishek
All the variables name has been addressed as per the comment. PTAL ! https://codereview.chromium.org/410283003/diff/1/content/shell/renderer/test_runner/mock_spell_check.cc File ...
6 years, 5 months ago (2014-07-24 10:08:39 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nit addressed https://codereview.chromium.org/410283003/diff/20001/content/shell/renderer/test_runner/mock_spell_check.h File content/shell/renderer/test_runner/mock_spell_check.h (right): https://codereview.chromium.org/410283003/diff/20001/content/shell/renderer/test_runner/mock_spell_check.h#newcode41 content/shell/renderer/test_runner/mock_spell_check.h:41: int* misspelledOffset, mispelled_offset
6 years, 5 months ago (2014-07-24 12:17:21 UTC) #3
Abhishek
Resolved comments inside mock_spell_check.h. Also corrected indentation as per chromium style of 80 chars inside ...
6 years, 5 months ago (2014-07-24 12:57:13 UTC) #4
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-24 13:49:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/410283003/40001
6 years, 5 months ago (2014-07-24 13:51:14 UTC) #6
jochen (gone - plz use gerrit)
you'll need to update the BUILD.gn file as well otherwise still lgtm
6 years, 5 months ago (2014-07-24 14:53:07 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 15:35:08 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 15:44:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/28979)
6 years, 5 months ago (2014-07-24 15:44:46 UTC) #10
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 5 months ago (2014-07-25 07:58:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/410283003/80001
6 years, 5 months ago (2014-07-25 07:59:14 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 12:20:07 UTC) #13
Message was sent while issue was closed.
Change committed as 285566

Powered by Google App Engine
This is Rietveld 408576698