Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 410263002: Oilpan: fix WebSockets unit tests after r178758. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Oilpan: fix WebSockets unit tests after r178758. Explicitly disconnect the channel on test completion, putting the heap object in the expected state by the time the next GC sweep happens. TBR=oilpan-reviews@chromium.org,tyoshino@chromium.org,yhirano@chromium.org,hiroshige@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/modules/websockets/NewWebSocketChannelImplTest.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-23 19:18:54 UTC) #1
sof
cf. failure seen, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan%20%28dbg%29/builds/3915
6 years, 5 months ago (2014-07-23 19:20:13 UTC) #2
sof
Pre-emptively landing this to fix the builds. If it is preferable to address this differently, ...
6 years, 5 months ago (2014-07-23 19:34:42 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-23 19:34:46 UTC) #4
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-23 19:34:52 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-23 19:35:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/410263002/1
6 years, 5 months ago (2014-07-23 19:36:02 UTC) #7
commit-bot: I haz the power
Change committed as 178778
6 years, 5 months ago (2014-07-23 19:36:37 UTC) #8
haraken
LGTM
6 years, 5 months ago (2014-07-23 23:32:50 UTC) #9
tyoshino (SeeGerritForStatus)
6 years, 5 months ago (2014-07-24 03:24:28 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698