Issue 410223003: location.reload() after POST should re-POST

Issue 410223003: location.reload() after POST should re-POST (Closed)

Created:
6 years, 5 months ago by Nate Chapin

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

location.reload() after POST should re-POST Currently, location.reload() always triggers a get. Change it to go through the FrameLoaer::reload() path, like a user-initiated reload. This aligns our behavior with firefox and IE. BUG=6429 TEST=http/tests/navigation/location-reload-after-post.php Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179176

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comment about ClientRedirectPolicy in FrameLoader::reload() #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -14 lines)			Patch
A	LayoutTests/http/tests/navigation/location-reload-after-post.php	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/navigation/location-reload-after-post-expected.txt	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/loader/FrameLoader.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
M	Source/core/loader/NavigationScheduler.cpp	View		2 chunks	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

https://codereview.chromium.org/410223003/diff/1/LayoutTests/http/tests/navigation/location-reload-after-post.php File LayoutTests/http/tests/navigation/location-reload-after-post.php (right): https://codereview.chromium.org/410223003/diff/1/LayoutTests/http/tests/navigation/location-reload-after-post.php#newcode1 LayoutTests/http/tests/navigation/location-reload-after-post.php:1: <body> For reasons I don't understand, the layout test ...

6 years, 4 months ago (2014-07-28 20:05:05 UTC) #1

abarth-chromium

LGTM assuming we want to change the GET to a POST. Ideally, we'd include some ...

6 years, 4 months ago (2014-07-29 16:58:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/410223003/20001

6 years, 4 months ago (2014-07-29 19:19:21 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 4 months ago (2014-07-29 20:33:49 UTC) #5

Message was sent while issue was closed.

Change committed as 179176

Expand Messages | Collapse Messages