Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 410213002: Revert 284930 "Use libc++ for all non-Windows ASan builds." (Closed)

Created:
6 years, 5 months ago by Alexei Svitkine (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284930 "Use libc++ for all non-Windows ASan builds." Broke Mac ASan Builder gclient runhooks step: Error: Command /Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium returned non-zero exit status 1 in /Volumes/data/b/build/slave/Mac_ASan_Builder/build Updating projects from gyp files... Using overrides found in /Users/chrome-bot/.gyp/include.gypi gyp: Found /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/third_party/libc++/libc++.gyp:libcxx_proxy#target in dependencies! of /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/base/base.gyp:sanitizer_options#target, but not in dependencies builder -> 'ninja' gyp_defines -> {'asan': '1', 'gomadir': '/Volumes/data/b/build/goma', 'use_goma': '1', 'component': 'static_library', 'release_extra_cflags': '-gline-tables-only'} IsWindows -> False IsLinux -> False platform -> 'mac' Running build/landmines.py... Hook '/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium' took 51.21 secs > Use libc++ for all non-Windows ASan builds. > > BUG=318770 > TBR=earthdok@chromium.org > > Review URL: https://codereview.chromium.org/414703002 TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexei Svitkine (slow)
6 years, 5 months ago (2014-07-23 15:50:21 UTC) #1
Alexei Svitkine (slow)
Committed patchset #1 manually as r284932 (tree was closed).
6 years, 5 months ago (2014-07-23 15:50:27 UTC) #2
Alexander Potapenko
6 years, 5 months ago (2014-07-23 15:51:23 UTC) #3
Message was sent while issue was closed.
On 2014/07/23 15:50:27, Alexei Svitkine wrote:
> Committed patchset #1 manually as r284932 (tree was closed).

LGTM

Powered by Google App Engine
This is Rietveld 408576698