DescriptionRevert 284930 "Use libc++ for all non-Windows ASan builds."
Broke Mac ASan Builder gclient runhooks step:
Error: Command /Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium returned non-zero exit status 1 in /Volumes/data/b/build/slave/Mac_ASan_Builder/build
Updating projects from gyp files...
Using overrides found in /Users/chrome-bot/.gyp/include.gypi
gyp: Found /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/third_party/libc++/libc++.gyp:libcxx_proxy#target in dependencies! of /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/base/base.gyp:sanitizer_options#target, but not in dependencies
builder -> 'ninja'
gyp_defines -> {'asan': '1', 'gomadir': '/Volumes/data/b/build/goma', 'use_goma': '1', 'component': 'static_library', 'release_extra_cflags': '-gline-tables-only'}
IsWindows -> False
IsLinux -> False
platform -> 'mac'
Running build/landmines.py...
Hook '/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium' took 51.21 secs
> Use libc++ for all non-Windows ASan builds.
>
> BUG=318770
> TBR=earthdok@chromium.org
>
> Review URL: https://codereview.chromium.org/414703002
TBR=glider@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284932
Patch Set 1 #
Messages
Total messages: 3 (0 generated)
|