Issue 410203002: X87: Move function prototype handling into a special handler rather than IC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 410203002: X87: Move function prototype handling into a special handler rather than IC (Closed)

Created:
6 years, 5 months ago by chunyang.dai

Modified:
6 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, danno

Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

X87: Move function prototype handling into a special handler rather than IC port r22526. original commit message: Move function prototype handling into a special handler rather than IC Adjust hydrogen handling of function.prototype to be based on map feedback. Handle non-instance prototype loading using an IC rather than in the hydrogen instruction. In the future, remove the special instruction and replace by multiple hydrogen instructions. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22585

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -16 lines)			Patch
	M	src/x87/lithium-codegen-x87.cc	View		2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chunyang.dai

Hello. Toon & Danno. Please help to review and commit this porting patch. The owner ...

6 years, 5 months ago (2014-07-23 16:31:15 UTC) #1

Toon Verwaest

6 years, 5 months ago (2014-07-24 09:12:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22585 (presubmit successful).

Expand Messages | Collapse Messages