Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: test/cctest/test-parsing.cc

Issue 410153002: Make --always-opt also optimize toplevel code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Jacob Bramley. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/mjsunit/debug-compile-event-newfunction.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index f55a625d6b6b5ff72a18525c6ff2667d26c9025b..f299b9f056e435867af9f8bb1cb145ce1dc1f2ea 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -2985,8 +2985,8 @@ namespace {
int* global_use_counts = NULL;
-void MockUseCounterCallback(v8::Isolate* isolate,
- v8::Isolate::UseCounterFeature feature) {
+void UseCounterCallback(v8::Isolate* isolate,
+ v8::Isolate::UseCounterFeature feature) {
++global_use_counts[feature];
}
@@ -2999,12 +2999,13 @@ TEST(UseAsmUseCount) {
LocalContext env;
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
global_use_counts = use_counts;
- CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
+ CcTest::isolate()->SetUseCounterCallback(UseCounterCallback);
CompileRun("\"use asm\";\n"
"var foo = 1;\n"
"\"use asm\";\n" // Only the first one counts.
"function bar() { \"use asm\"; var baz = 1; }");
- CHECK_EQ(2, use_counts[v8::Isolate::kUseAsm]);
+ // Optimizing will double-count because the source is parsed twice.
+ CHECK_EQ(i::FLAG_always_opt ? 4 : 2, use_counts[v8::Isolate::kUseAsm]);
}
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/mjsunit/debug-compile-event-newfunction.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698