Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-debug.cc

Issue 410153002: Make --always-opt also optimize toplevel code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/factory.cc ('K') | « test/cctest/test-api.cc ('k') | test/cctest/test-decls.cc » ('j') | test/cctest/test-heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 6623a3ed95e7d242841615860fe5360e9242a92b..7faad1745792bae58d0313e1c420773004ba99e9 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -6624,6 +6624,10 @@ TEST(Backtrace) {
v8::Debug::SetMessageHandler(BacktraceData::MessageHandler);
+ // TODO(mstarzinger): This doesn't work with --always-opt because we don't
+ // have correct source positions in optimized code. Enable once we have.
+ i::FLAG_always_opt = false;
+
const int kBufferSize = 1000;
uint16_t buffer[kBufferSize];
const char* scripts_command =
« src/factory.cc ('K') | « test/cctest/test-api.cc ('k') | test/cctest/test-decls.cc » ('j') | test/cctest/test-heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698