Make --always-opt also optimize toplevel code.

src/arm64/lithium-codegen-arm64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/arm64/lithium-codegen-arm64.h"
 #include "src/arm64/lithium-gap-resolver-arm64.h"
 #include "src/code-stubs.h"
 #include "src/hydrogen-osr.h"
@@ skipping 671 matching lines @@
   if (info()->saves_caller_doubles()) {
     SaveCallerDoubles();
   }
 
   // Allocate a local context if needed.
   int heap_slots = info()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
   if (heap_slots > 0) {
     Comment(";;; Allocate local context");
     bool need_write_barrier = true;
     // Argument to NewContext is the function, which is in x1.
-    if (heap_slots <= FastNewContextStub::kMaximumSlots) {
+    if (FLAG_harmony_scoping && info()->scope()->is_global_scope()) {
+      __ Push(x1);
+      __ Push(info()->scope()->GetScopeInfo());

[jbramley, 2014/07/28 16:00:32]

I think it would be slightly better load the scope info explicity so we can
merge the pushes:

UseScratchRegisterScope temps(masm);
Register scope_info = temps.AcquireX();
__ Mov(scope_info, Operand(info()->scope()->GetScopeInfo()));
__ Push(x1, scope_info);

Each 'Push' has an overhead, and Push(Handle<ScopeInfo>) will just load the
handle into a scratch register anyway so the 'Mov' here doesn't have any extra
cost.

[Michael Starzinger, 2014/07/28 16:15:53]

Done.

+      __ CallRuntime(Runtime::kNewGlobalContext, 2);
+    } else if (heap_slots <= FastNewContextStub::kMaximumSlots) {
       FastNewContextStub stub(isolate(), heap_slots);
       __ CallStub(&stub);
       // Result of FastNewContextStub is always in new space.
       need_write_barrier = false;
     } else {
       __ Push(x1);
       __ CallRuntime(Runtime::kNewFunctionContext, 1);
     }
     RecordSafepoint(Safepoint::kNoLazyDeopt);
     // Context is returned in x0. It replaces the context passed to us. It's
@@ skipping 4324 matching lines @@
 void LCodeGen::DoDebugBreak(LDebugBreak* instr) {
   __ Debug("LDebugBreak", 0, BREAK);
 }
 
 
 void LCodeGen::DoDeclareGlobals(LDeclareGlobals* instr) {
   ASSERT(ToRegister(instr->context()).is(cp));
   Register scratch1 = x5;
   Register scratch2 = x6;
   ASSERT(instr->IsMarkedAsCall());
-
-  ASM_UNIMPLEMENTED_BREAK("DoDeclareGlobals");

[jbramley, 2014/07/28 16:00:32]

We used ASM_UNIMPLEMENTED_BREAK during development. I thought they were all
gone, to be honest. This one probably remains because we couldn't test this
code. (That is, it's probably safe to remove it.)

[Michael Starzinger, 2014/07/28 16:15:53]

Acknowledged. This actually was the last use. Would you be fine if I removed the
macro (and the related flag) in a follow-up CL or do you intend to keep this
around?

[jbramley, 2014/07/28 16:28:11]

I see no reason to keep it. We can recreate it fairly easily if we ever find
that we need it again, but it seems unlikely.

   // TODO(all): if Mov could handle object in new space then it could be used
   // here.
   __ LoadHeapObject(scratch1, instr->hydrogen()->pairs());
   __ Mov(scratch2, Smi::FromInt(instr->hydrogen()->flags()));
   __ Push(cp, scratch1, scratch2);  // The context is the first argument.
   CallRuntime(Runtime::kDeclareGlobals, 3, instr);
 }
 
 
 void LCodeGen::DoDeferredStackCheck(LStackCheck* instr) {
@@ skipping 1005 matching lines @@
   Handle<ScopeInfo> scope_info = instr->scope_info();
   __ Push(scope_info);
   __ Push(ToRegister(instr->function()));
   CallRuntime(Runtime::kPushBlockContext, 2, instr);
   RecordSafepoint(Safepoint::kNoLazyDeopt);
 }
 
 
 
 } }  // namespace v8::internal