Issue 410113002: Fix WiFi config view for previously configured client cert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 410113002: Fix WiFi config view for previously configured client cert. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)

Modified:
6 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix WiFi config view for previously configured client cert. Before, wifi_config_view expected to read only a plain PKCS#11 ID from the shill::kEapCertIdProperty. However the format changed to '<slot_id>:<key_id>' since the system token is enabled in ChromeOS. This lead to the view not correctly pre-selecting the previously configured certificate. With this change, the property is correctly parsed and the pre-selection works again for certificates from the user's slot. BUG=358366, 396181 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285806

Patch Set 1 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -2 lines)			Patch
M	chrome/browser/chromeos/options/wifi_config_view.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chromeos/network/client_cert_util.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chromeos/network/client_cert_util.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

The CQ bit was checked by pneubeck@chromium.org

6 years, 4 months ago (2014-07-26 15:58:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/410113002/20001

6 years, 4 months ago (2014-07-26 16:00:53 UTC) #4

Message was sent while issue was closed.

Change committed as 285806

Expand Messages | Collapse Messages