Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 410083003: Add new ICU to aosp_manifest.xml (Closed)

Created:
6 years, 5 months ago by hjd
Modified:
6 years, 5 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add new ICU to aosp_manifest.xml BUG=395244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285014

Patch Set 1 #

Patch Set 2 : Also roll other ICU #

Patch Set 3 : 2nd attempt to roll both ICUs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/buildbot/aosp_manifest.xml View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
hjd
ptal
6 years, 5 months ago (2014-07-23 14:51:01 UTC) #1
mkosiba (inactive)
lgtm
6 years, 5 months ago (2014-07-23 14:51:10 UTC) #2
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 5 months ago (2014-07-23 14:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/410083003/30002
6 years, 5 months ago (2014-07-23 14:52:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 16:48:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 17:08:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173829)
6 years, 5 months ago (2014-07-23 17:09:00 UTC) #7
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 5 months ago (2014-07-23 17:26:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/410083003/30002
6 years, 5 months ago (2014-07-23 17:28:27 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 19:35:51 UTC) #10
Message was sent while issue was closed. 
Change committed as 285014

Powered by Google App Engine
This is Rietveld 408576698