Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 410083002: [SyncFS] Add missing LocalFileChangeTracker::UpdateNumChanges call (1.5/3) (Closed)

Created:
6 years, 5 months ago by tzik
Modified:
6 years, 5 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Add missing LocalFileChangeTracker::UpdateNumChanges call NOTRY=true BUG=344769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tzik
PTL
6 years, 5 months ago (2014-07-23 06:08:21 UTC) #1
nhiroki
lgtm
6 years, 5 months ago (2014-07-23 06:17:03 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 5 months ago (2014-07-23 06:40:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/410083002/1
6 years, 5 months ago (2014-07-23 06:41:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 11:46:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 12:22:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31459)
6 years, 5 months ago (2014-07-23 12:22:16 UTC) #7
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 5 months ago (2014-07-23 13:42:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/410083002/1
6 years, 5 months ago (2014-07-23 13:43:20 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 14:17:40 UTC) #10
Message was sent while issue was closed. 
Change committed as 284915

Powered by Google App Engine
This is Rietveld 408576698