Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9092)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/views/menu.cc

Issue 41006: Fixes regression in menus. Specifically selecting by way of press,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/views/menu.cc
===================================================================
--- chrome/views/menu.cc (revision 11261)
+++ chrome/views/menu.cc (working copy)
@@ -554,9 +554,10 @@
delegate_->MenuWillShow();
- // Show the menu. Blocks until the menu is dismissed or an item is chosen.
+ // NOTE: we don't use TPM_RIGHTBUTTON here as it breaks selecting by way of
+ // press, drag, release. See bugs 718 and 8560.
UINT flags =
- GetTPMAlignFlags() | TPM_RIGHTBUTTON | TPM_RETURNCMD | TPM_RECURSE;
+ GetTPMAlignFlags() | TPM_LEFTBUTTON | TPM_RETURNCMD | TPM_RECURSE;
is_menu_visible_ = true;
DCHECK(owner_);
// In order for context menus on menus to work, the context menu needs to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698