Fixes regression in menus. Specifically selecting by way of press,...

Fixes regression in menus. Specifically selecting by way of press,
drag then release was broken. It appears that TPM_RIGHTBUTTON
disallows this behavior.

BUG=8560
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11280

[Finnur, 2009-03-09 19:55:54]

http://codereview.chromium.org/41006/diff/1/2
File chrome/views/menu.cc (right):

http://codereview.chromium.org/41006/diff/1/2#newcode560
Line 560: GetTPMAlignFlags() | TPM_LEFTBUTTON | TPM_RETURNCMD | TPM_RECURSE;
Won't this regress bug 718?

[Finnur, 2009-03-09 20:04:22]

I agree that the bug you are trying to fix is more important than bug 718, but I
am worried that someone will try to fix bug 718 and regress this again. Can you
add a comment explaining why we chose TPM_LEFTBUTTON over TPM_RIGHTBUTTON (and
perhaps refer to the two bugs) so that the next person can have all the info and
try a different approach (or get TPM_RIGHTBUTTON to work with regressing).

... and remember to reopen bug 718.

On 2009/03/09 19:55:54, Finnur wrote:
> http://codereview.chromium.org/41006/diff/1/2
> File chrome/views/menu.cc (right):
> 
> http://codereview.chromium.org/41006/diff/1/2#newcode560
> Line 560: GetTPMAlignFlags() | TPM_LEFTBUTTON | TPM_RETURNCMD | TPM_RECURSE;
> Won't this regress bug 718?

[Finnur, 2009-03-09 20:15:10]

LGTM

[sky, 2009-03-13 00:10:32]

OK