Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 410043003: Video Player: Use Google Cast API extension instead of deprecated way (Closed)

Created:
6 years, 5 months ago by yoshiki
Modified:
6 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Video Player: Use Google Cast API extension Previously the video player used old way to control a cast, but it's now deprecated and we need to migrate to new way. BUG=305511 TEST=List of casts is shown R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284902

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -28 lines) Patch
M ui/file_manager/video_player/js/cast/caster.js View 1 2 chunks +65 lines, -24 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/file_manager/video_player/manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/video_player.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 5 months ago (2014-07-23 04:16:57 UTC) #1
hirono
lgtm with a nit. https://codereview.chromium.org/410043003/diff/50001/ui/file_manager/video_player/js/cast/caster.js File ui/file_manager/video_player/js/cast/caster.js (right): https://codereview.chromium.org/410043003/diff/50001/ui/file_manager/video_player/js/cast/caster.js#newcode54 ui/file_manager/video_player/js/cast/caster.js:54: function initializeApi() { nit: missing ...
6 years, 5 months ago (2014-07-23 04:37:32 UTC) #2
yoshiki
https://codereview.chromium.org/410043003/diff/50001/ui/file_manager/video_player/js/cast/caster.js File ui/file_manager/video_player/js/cast/caster.js (right): https://codereview.chromium.org/410043003/diff/50001/ui/file_manager/video_player/js/cast/caster.js#newcode54 ui/file_manager/video_player/js/cast/caster.js:54: function initializeApi() { On 2014/07/23 04:37:31, hirono wrote: > ...
6 years, 5 months ago (2014-07-23 05:07:32 UTC) #3
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 5 months ago (2014-07-23 05:07:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/410043003/70001
6 years, 5 months ago (2014-07-23 05:09:41 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 07:03:06 UTC) #6
yoshiki
The CQ bit was unchecked by yoshiki@chromium.org
6 years, 5 months ago (2014-07-23 07:50:18 UTC) #7
yoshiki
6 years, 5 months ago (2014-07-23 11:17:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r284902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698