chrome/browser/chromeos/file_manager/file_manager_browsertest.cc - Issue 410043002: Disable all the browser_tests that are flaking more than 5% of the time on trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 410043002: Disable all the browser_tests that are flaking more than 5% of the time on trybots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc ('k') | chrome/browser/chromeos/login/kiosk_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

index a29df2671e163516ee6e90771c818c26fbf9b9fb..d419cc894d27de1ecce13396bc35e14386ee62a9 100644

--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

@@ -746,7 +746,8 @@ class FileManagerBrowserTest :

}

};

-IN_PROC_BROWSER_TEST_P(FileManagerBrowserTest, Test) {

+// http://crbug.com/327719

+IN_PROC_BROWSER_TEST_P(FileManagerBrowserTest, DISABLED_Test) {

StartTest();

}

@@ -774,14 +775,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(

TestParameter(NOT_IN_GUEST_MODE, "fileDisplayDrive"),

TestParameter(NOT_IN_GUEST_MODE, "fileDisplayMtp")));

-// Slow tests are disabled on debug build. http://crbug.com/327719

-#if !defined(NDEBUG)

-#define MAYBE_OpenZipFiles DISABLED_OpenZipFiles

-#else

-#define MAYBE_OpenZipFiles OpenZipFiles

-#endif

+// http://crbug.com/327719

WRAPPED_INSTANTIATE_TEST_CASE_P(

- MAYBE_OpenZipFiles,

+ DISABLED_OpenZipFiles,

FileManagerBrowserTest,

::testing::Values(TestParameter(IN_GUEST_MODE, "zipOpenDownloads"),

TestParameter(NOT_IN_GUEST_MODE, "zipOpenDownloads"),