extensions/common/permissions/permission_message_util.h - Issue 410023002: Show read-only messages for non-interact non-desktop Automation extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permission_message_util.h

Issue 410023002: Show read-only messages for non-interact non-desktop Automation extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: re-rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/permission_message.h ('k') | extensions/common/permissions/permission_message_util.cc » ('j') | extensions/common/permissions/permission_message_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/permission_message_util.h

diff --git a/extensions/common/permissions/permission_message_util.h b/extensions/common/permissions/permission_message_util.h

index 410e1a2816696ff4afa704d719211ddc3d0ccd1c..dda159fb37ece2d13c15ffe714ccfe1cfe0540d5 100644

--- a/extensions/common/permissions/permission_message_util.h

+++ b/extensions/common/permissions/permission_message_util.h

@@ -17,7 +17,11 @@ class URLPatternSet;

namespace permission_message_util {

// Creates the corresponding permission message for a list of hosts.

-// The messages change depending on what hosts are present.

+// The messages change depending on how many hosts are present, and whether

+// |read_only| is true.

+extensions::PermissionMessage CreateFromHostList(

+ const std::set<std::string>& hosts,

+ bool read_only);

not at google - send to devlin 2014/07/25 18:17:42 ideally this would be an enum not a bool

aboxhall 2014/07/25 19:06:31 Done.

extensions::PermissionMessage CreateFromHostList(

const std::set<std::string>& hosts);

not at google - send to devlin 2014/07/25 18:17:42 could you remove this override? this only has 2 ca

aboxhall 2014/07/25 19:06:31 Done.