Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 409903003: Update the Easy Unlock manifest.json file for new APIs and scopes. (Closed)

Created:
6 years, 5 months ago by Tim Song
Modified:
6 years, 5 months ago
Reviewers:
xiyuan, tbarzic
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update the Easy Unlock manifest.json file for new APIs and scopes. BUG=390230 TEST=manual NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284757

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/browser/resources/easy_unlock/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/easy_unlock/manifest.json View 1 2 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Tim Song
6 years, 5 months ago (2014-07-22 18:36:31 UTC) #1
tbarzic
lgtm https://codereview.chromium.org/409903003/diff/1/chrome/browser/resources/easy_unlock/manifest.json File chrome/browser/resources/easy_unlock/manifest.json (right): https://codereview.chromium.org/409903003/diff/1/chrome/browser/resources/easy_unlock/manifest.json#newcode43 chrome/browser/resources/easy_unlock/manifest.json:43: nit: remove the line
6 years, 5 months ago (2014-07-22 18:37:59 UTC) #2
Tim Song
https://codereview.chromium.org/409903003/diff/1/chrome/browser/resources/easy_unlock/manifest.json File chrome/browser/resources/easy_unlock/manifest.json (right): https://codereview.chromium.org/409903003/diff/1/chrome/browser/resources/easy_unlock/manifest.json#newcode43 chrome/browser/resources/easy_unlock/manifest.json:43: On 2014/07/22 18:37:58, tbarzic wrote: > nit: remove the ...
6 years, 5 months ago (2014-07-22 19:24:56 UTC) #3
Tim Song
The CQ bit was checked by tengs@chromium.org
6 years, 5 months ago (2014-07-22 19:25:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/409903003/20001
6 years, 5 months ago (2014-07-22 19:26:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 19:27:57 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/easy_unlock/manifest.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-22 19:27:58 UTC) #7
Tim Song
The CQ bit was checked by tengs@chromium.org
6 years, 5 months ago (2014-07-22 19:38:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/409903003/40001
6 years, 5 months ago (2014-07-22 19:39:14 UTC) #9
xiyuan
lgtm
6 years, 5 months ago (2014-07-22 19:39:27 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 19:41:03 UTC) #11
Message was sent while issue was closed.
Change committed as 284757

Powered by Google App Engine
This is Rietveld 408576698