GCM: D-Bus methods for wake-on-packet

components/gcm_driver/default_gcm_app_handler.h

Index: components/gcm_driver/default_gcm_app_handler.h
diff --git a/components/gcm_driver/default_gcm_app_handler.h b/components/gcm_driver/default_gcm_app_handler.h
index 57613a54bada666684f9ac0c95a70b97c2fd295a..cc3e670f08367dc5b2f90482eab1a0dd9398735f 100644
--- a/components/gcm_driver/default_gcm_app_handler.h
+++ b/components/gcm_driver/default_gcm_app_handler.h
@@ -7,6 +7,7 @@
 
 #include "base/compiler_specific.h"
 #include "components/gcm_driver/gcm_app_handler.h"
+#include "net/base/ip_endpoint.h"

[Daniel Erat, 2014/08/21 22:17:38]

nit: forward-declare

[Luigi Semenzato, 2014/08/22 01:08:19]

Done.

 
 namespace gcm {
 
@@ -30,6 +31,12 @@ class DefaultGCMAppHandler : public GCMAppHandler {
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DefaultGCMAppHandler);
+  static void NullCallback(const std::string& result);

[Daniel Erat, 2014/08/21 22:17:38]

delete these? i don't see them defined in the .cc file.

private static methods should usually be functions in an anonymous namespace in
the .cc file instead.

[Luigi Semenzato, 2014/08/22 01:08:19]

Done.

+  static void ErrorCallback(const std::string& error_name,
+                            const std::string& error);
+
+  static void (*on_connected_cb_)(const net::IPEndPoint& ip_endpoint);
+  static void (*on_disconnected_cb_)();
 };
 
 }  // namespace gcm