GCM: D-Bus methods for wake-on-packet

chromeos/dbus/shill_manager_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_SHILL_MANAGER_CLIENT_H_
 #define CHROMEOS_DBUS_SHILL_MANAGER_CLIENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 174 matching lines @@
       const base::DictionaryValue& properties,
       const ObjectPathCallback& callback,
       const ErrorCallback& error_callback) = 0;
 
   // Calls GetService method.
   // |callback| is called after the method call succeeds.
   virtual void GetService(const base::DictionaryValue& properties,
                           const ObjectPathCallback& callback,
                           const ErrorCallback& error_callback) = 0;
 
-  // Verify that the given data corresponds to a trusted device, and return true
-  // to the callback if it is.
+  // Verifies that the given data corresponds to a trusted device, and returns
+  // true to the callback if it is.
   virtual void VerifyDestination(const VerificationProperties& properties,
                                  const BooleanCallback& callback,
                                  const ErrorCallback& error_callback) = 0;
 
-  // Verify that the given data corresponds to a trusted device, and if it is,
-  // return the encrypted credentials for connecting to the network represented
+  // Verifies that the given data corresponds to a trusted device, and if it is,
+  // returns the encrypted credentials for connecting to the network represented
   // by the given |service_path|, encrypted using the |public_key| for the
-  // trusted device. If the device is not trusted, return the empty string.
+  // trusted device. If the device is not trusted, returns the empty string.
   virtual void VerifyAndEncryptCredentials(
       const VerificationProperties& properties,
       const std::string& service_path,
       const StringCallback& callback,
       const ErrorCallback& error_callback) = 0;
 
-  // Verify that the given data corresponds to a trusted device, and return the
-  // |data| encrypted using the |public_key| for the trusted device. If the
-  // device is not trusted, return the empty string.
+  // Verifies that the given data corresponds to a trusted device, and returns
+  // the |data| encrypted using the |public_key| for the trusted device. If the
+  // device is not trusted, returns the empty string.
   virtual void VerifyAndEncryptData(const VerificationProperties& properties,
                                     const std::string& data,
                                     const StringCallback& callback,
                                     const ErrorCallback& error_callback) = 0;
 
-  // For each technology present, connect to the "best" service available.
+  // For each technology present, connects to the "best" service available.
   // Called once the user is logged in and certificates are loaded.
   virtual void ConnectToBestServices(const base::Closure& callback,
                                      const ErrorCallback& error_callback) = 0;
 
+  // Requests that shill program the NIC so that packets incoming on
+  // |ip_connection| wake up the CPU.
+  virtual void AddWakeOnPacketConnection(
+      const std::string& ip_connection,

[Daniel Erat, 2014/08/21 22:17:38]

think i mentioned this earlier, but please either use a more-specific type than
std::string for this or document exactly what the format is or where's it's
defined

[Luigi Semenzato, 2014/08/22 01:08:19]

Sorry, I was still hoping to have coarse-level reviews, so I haven't changed
these before, but I am doing it now.

Done.

+      const base::Closure& callback,
+      const ErrorCallback& error_callback) = 0;
+
+  // Removes a request to wake up on packets coming on |ip_connection|.
+  virtual void RemoveWakeOnPacketConnection(
+      const std::string& ip_connection,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) = 0;
+
+  // Clears all requests to wake up on packets.
+  virtual void RemoveAllWakeOnPacketConnections(
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) = 0;
+
   // Returns an interface for testing (stub only), or returns NULL.
   virtual TestInterface* GetTestInterface() = 0;
 
  protected:
   friend class ShillManagerClientTest;
 
   // Create() should be used instead.
   ShillManagerClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShillManagerClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_SHILL_MANAGER_CLIENT_H_