GCM: D-Bus methods for wake-on-packet

chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_gcm_app_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 38 matching lines @@
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
 #endif
 
 namespace extensions {
 
 namespace {
 
 const char kTestExtensionName[] = "FooBar";
 const char kTestingUsername[] = "user1@example.com";
 
 }  // namespace
@@ skipping 144 matching lines @@
     thread_bundle_.reset(new content::TestBrowserThreadBundle(
         content::TestBrowserThreadBundle::REAL_IO_THREAD));
 
     // Allow extension update to unpack crx in process.
     in_process_utility_thread_helper_.reset(
         new content::InProcessUtilityThreadHelper);
 
     // This is needed to create extension service under CrOS.
 #if defined(OS_CHROMEOS)
     test_user_manager_.reset(new chromeos::ScopedTestUserManager());
+    // Create a DBus thread manager setter for its side effect.
+    (void) chromeos::DBusThreadManager::GetSetterForTesting();

[Yoyo Zhou, 2014/09/13 00:50:47]

What is this (void) doing here?

[Luigi Semenzato, 2014/09/13 01:02:48]

The function returns a value which I ignore, as I thought was clear from the
comment (obviously it is not).  Should I omit the (void)?

[Yoyo Zhou, 2014/09/13 01:09:43]

The usage looks pretty uncommon in src/chrome, so I would say you can omit it.

 #endif
 
     // Create a new profile.
     TestingProfile::Builder builder;
     builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
                               gcm::FakeSigninManager::Build);
     profile_ = builder.Build();
     signin_manager_ = static_cast<gcm::FakeSigninManager*>(
         SigninManagerFactory::GetInstance()->GetForProfile(profile_.get()));
 
@@ skipping 252 matching lines @@
 
   // App handler is removed when the extension is updated to the version that
   // has GCM permission removed.
   UpdateExtension(extension.get(), "good2.crx");
   waiter()->PumpUILoop();
   EXPECT_TRUE(gcm_app_handler()->app_handler_count_drop_to_zero());
   EXPECT_FALSE(HasAppHandlers(extension->id()));
 }
 
 }  // namespace extensions