GCM: D-Bus methods for wake-on-packet

chrome/browser/services/gcm/chromeos_gcm_connection_observer.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SERVICES_GCM_CHROMEOS_GCM_CONNECTION_OBSERVER_H_
+#define CHROME_BROWSER_SERVICES_GCM_CHROMEOS_GCM_CONNECTION_OBSERVER_H_
+
+#include "base/compiler_specific.h"
+#include "components/gcm_driver/gcm_connection_observer.h"
+#include "net/base/ip_endpoint.h"

[fgorski, 2014/09/08 21:48:18]

nit: you can forward declare it here I think.

[Luigi Semenzato, 2014/09/11 18:43:33]

I don't think so, I have a class member of type IPEndPoint below.

+

[fgorski, 2014/09/08 21:48:18]

nit: extra line not necessary

[Luigi Semenzato, 2014/09/11 18:43:33]

Done.

+
+namespace gcm {
+
+class ChromeOSGCMConnectionObserver : public GCMConnectionObserver {
+ public:
+  ChromeOSGCMConnectionObserver();
+  virtual ~ChromeOSGCMConnectionObserver();
+  virtual void OnConnected(const net::IPEndPoint& ip_endpoint) OVERRIDE;

[fgorski, 2014/09/08 21:48:18]

nit: add comment above:

// gcm::GCMConnectionObserver implementation:

[Luigi Semenzato, 2014/09/11 18:43:33]

Done.

+  virtual void OnDisconnected() OVERRIDE;
+
+  static void ErrorCallback(
+      const std::string& error_name,
+      const std::string& error);
+
+ private:
+  net::IPEndPoint ip_endpoint_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeOSGCMConnectionObserver);
+};
+
+}  // namespace gcm
+
+#endif  // CHROME_BROWSER_SERVICES_GCM_CHROMEOS_GCM_CONNECTION_OBSERVER_H_