Issue 409863002: Suspend shared timers while blockingly closing databases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409863002: Suspend shared timers while blockingly closing databases (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 5 months ago

Reviewers:
michaeln

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Suspend shared timers while blockingly closing databases BUG=388771 R=michaeln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284785

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	content/renderer/render_thread_impl.cc	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

michaeln

https://codereview.chromium.org/409863002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/409863002/diff/1/content/renderer/render_thread_impl.cc#newcode580 content/renderer/render_thread_impl.cc:580: WebView::willEnterModalLoop(); lgtm (kinda)

6 years, 5 months ago (2014-07-22 20:21:47 UTC) #2

jochen (gone - plz use gerrit)

The CQ bit was checked by jochen@chromium.org

6 years, 5 months ago (2014-07-22 20:53:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/409863002/1

6 years, 5 months ago (2014-07-22 20:56:12 UTC) #4

Message was sent while issue was closed.

Change committed as 284785

Expand Messages | Collapse Messages