Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 409833003: Internals.selectColorInColorChooser(): type check element argument. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Internals.selectColorInColorChooser(): type check element argument. Avoid trouble and verify that the incoming element is indeed an Element. R=keishi@chromium.org BUG=395970 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178662

Patch Set 1 #

Patch Set 2 : Add missing U+0020 #

Patch Set 3 : Expected output updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M LayoutTests/fast/forms/color/input-color-onchange-event.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/color/input-color-onchange-event-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-22 10:14:39 UTC) #1
tkent
+keishi
6 years, 5 months ago (2014-07-22 11:07:00 UTC) #2
keishi
lgtm
6 years, 5 months ago (2014-07-22 11:10:32 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-22 11:19:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/409833003/40001
6 years, 5 months ago (2014-07-22 11:19:56 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 12:13:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 13:17:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18256)
6 years, 5 months ago (2014-07-22 13:17:32 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-22 13:27:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/409833003/40001
6 years, 5 months ago (2014-07-22 13:28:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 13:45:54 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 14:50:44 UTC) #12
Message was sent while issue was closed.
Change committed as 178662

Powered by Google App Engine
This is Rietveld 408576698