Add a basic test for main frame swap.

Add a basic test for main frame swap.

This doesn't really invoke all the machinery involved in swapping
frames (a real frame swap would likely have a provisional local
frame before it committed into the frame tree, etc.) but it's
still helpful for catching problematic code.

BUG=346764
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183840

[dcheng, 2014-10-16 21:12:54]

dcheng@chromium.org changed reviewers:
+ japhet@chromium.org

[dcheng, 2014-10-16 21:13:18]

I wonder if we should convert these tests to use the provisional nav + swap
machinery that you're adding in https://codereview.chromium.org/643333002

[Nate Chapin, 2014-10-16 21:17:46]

Code LGTM

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
Source/web/tests/WebFrameTest.cpp:6538: // than it should.
This comment seems out of place?

[dcheng, 2014-10-16 21:20:20]

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
Source/web/tests/WebFrameTest.cpp:6538: // than it should.
On 2014/10/16 21:17:46, Nate Chapin wrote:
> This comment seems out of place?

It's about the call to loadFrame() below... but I don't recall why this fires
too many load events anymore (or if it even does).

[Nate Chapin, 2014-10-16 21:21:47]

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
Source/web/tests/WebFrameTest.cpp:6538: // than it should.
On 2014/10/16 21:20:20, dcheng wrote:
> On 2014/10/16 21:17:46, Nate Chapin wrote:
> > This comment seems out of place?
> 
> It's about the call to loadFrame() below... but I don't recall why this fires
> too many load events anymore (or if it even does).

Well, maybe I'm missing something, but I don't see any evidence of an iframe
anywhere in this test, so I don't understand how we could be firing load events
on one.

[dcheng, 2014-10-16 21:23:22]

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/409823002/diff/20001/Source/web/tests/WebFram...
Source/web/tests/WebFrameTest.cpp:6538: // than it should.
On 2014/10/16 21:21:47, Nate Chapin wrote:
> On 2014/10/16 21:20:20, dcheng wrote:
> > On 2014/10/16 21:17:46, Nate Chapin wrote:
> > > This comment seems out of place?
> > 
> > It's about the call to loadFrame() below... but I don't recall why this
fires
> > too many load events anymore (or if it even does).
> 
> Well, maybe I'm missing something, but I don't see any evidence of an iframe
> anywhere in this test, so I don't understand how we could be firing load
events
> on one.

Hm. Good point. I've removed this FIXME.

[dcheng, 2014-10-16 21:23:39]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-10-16 21:23:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/409823002/40001

[commit-bot: I haz the power, 2014-10-16 23:16:17]

Committed patchset #3 (id:40001) as 183840