Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc b/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
index 0074e2fbf44b6a4ec9b4d267486ba328463200ad..300de81e45e3f139dbed4e718b05884fc63e042d 100644
--- a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
+++ b/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
@@ -341,9 +341,7 @@ void SupervisedUserTestBase::StartUserCreation(
registration_utility_stub_->RunSuccessCallback("token");
// Token writing moves control to BlockingPool and back.
- base::RunLoop().RunUntilIdle();
- content::BrowserThread::GetBlockingPool()->FlushForTesting();
- base::RunLoop().RunUntilIdle();
+ content::RunAllBlockingPoolTasksUntilIdle();
JSExpect(StringPrintf("%s == 'created'", kCurrentPage));
JSEval("$('supervised-user-creation-gotit-button').click()");
@@ -390,7 +388,7 @@ void SupervisedUserTestBase::SigninAsManager(int user_index) {
}
void SupervisedUserTestBase::RemoveSupervisedUser(
- unsigned long original_user_count,
+ size_t original_user_count,
int user_index,
const std::string& expected_display_name) {
// Remove supervised user.

Powered by Google App Engine
This is Rietveld 408576698