Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
index 47371ce2257663baa78ab754f5165b6153b76424..ccf8b572b1bb4a7f23b0a18c9c08885dd22ce553 100644
--- a/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
+++ b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/browsing_data/browsing_data_local_storage_helper.h"
+
#include <string>
#include "base/basictypes.h"
@@ -16,12 +18,12 @@
#include "base/test/thread_test_helper.h"
#include "base/threading/sequenced_worker_pool.h"
#include "chrome/browser/browsing_data/browsing_data_helper_browsertest.h"
-#include "chrome/browser/browsing_data/browsing_data_local_storage_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/dom_storage_context.h"
+#include "content/public/test/test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
using content::BrowserContext;
@@ -126,7 +128,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataLocalStorageHelperTest, DeleteSingleFile) {
new BrowsingDataLocalStorageHelper(browser()->profile()));
CreateLocalStorageFilesForTest();
local_storage_helper->DeleteOrigin(GURL(kOriginOfTestFile0));
- BrowserThread::GetBlockingPool()->FlushForTesting();
+ content::RunAllBlockingPoolTasksUntilIdle();
// Ensure the file has been deleted.
base::FileEnumerator file_enumerator(

Powered by Google App Engine
This is Rietveld 408576698